Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java.io.FileNotFoundException #534

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

niorgai
Copy link
Contributor

@niorgai niorgai commented Jan 1, 2023

  1. Rename the method.
  2. Create the property directory if it does not exist, avoiding java.io.FileNotFoundException

1. Rename the method.
2. Create the property directory if it does not exist, avoiding `java.io.FileNotFoundException`
@swissiety swissiety self-requested a review January 2, 2023 09:15
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 63.46% // Head: 63.46% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a442d8d) compared to base (e0bca20).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #534   +/-   ##
==========================================
  Coverage      63.46%   63.46%           
  Complexity      3027     3027           
==========================================
  Files            290      290           
  Lines          13475    13476    +1     
  Branches        2143     2143           
==========================================
+ Hits            8552     8553    +1     
  Misses          4253     4253           
  Partials         670      670           
Impacted Files Coverage Δ
...ava/sourcecode/frontend/WalaJavaClassProvider.java 52.94% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swissiety
Copy link
Collaborator

maybe - we could move the properties file to a better path i.e. a directory that is not maven configuration dependent and would not need the proposed fix?

@niorgai
Copy link
Contributor Author

niorgai commented Jan 3, 2023

maybe - we could move the properties file to a better path i.e. a directory that is not maven configuration dependent and would not need the proposed fix?

Agree, but I am not familiar with maven, I just encountered this problem when running the code.
If there is a better solution, it would be better

@JRoper18
Copy link

JRoper18 commented Feb 2, 2023

Hey, I'm also running into this issue. Can this be merged?

@kadirayk kadirayk merged commit d28b5f8 into soot-oss:develop Feb 3, 2023
@FZhg
Copy link

FZhg commented Mar 9, 2023

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants