Add withAdditionalExtensions

sop · Jun 22, 2016 · 0989e16 · 0989e16
1 parent fb1238b
commit 0989e16
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/X509/AttributeCertificate/AttributeCertificateInfo.php b/lib/X509/AttributeCertificate/AttributeCertificateInfo.php
@@ -9,6 +9,7 @@
 use CryptoUtil\ASN1\AlgorithmIdentifier\Feature\SignatureAlgorithmIdentifier;
 use CryptoUtil\ASN1\PrivateKeyInfo;
 use CryptoUtil\Crypto\Crypto;
+use X509\Certificate\Extension\Extension;
 use X509\Certificate\Extensions;
 use X509\Certificate\UniqueIdentifier;
 
@@ -256,6 +257,18 @@ public function withExtensions(Extensions $extensions) {
 		return $obj;
 	}
 
+	/**
+	 * Get self with extensions added.
+	 *
+	 * @param Extension ...$exts One or more Extension objects
+	 * @return self
+	 */
+	public function withAdditionalExtensions(Extension ...$exts) {
+		$obj = clone $this;
+		$obj->_extensions = $obj->_extensions->withExtensions(...$exts);
+		return $obj;
+	}
+
 	/**
 	 * Get version.
 	 *

diff --git a/test/unit/ac/AttributeCertificateInfoTest.php b/test/unit/ac/AttributeCertificateInfoTest.php
@@ -301,6 +301,18 @@ public function testWithExtensions(AttributeCertificateInfo $aci) {
 		return $aci;
 	}
 
+	/**
+	 * @depends testCreate
+	 *
+	 * @param AttributeCertificateInfo $aci
+	 */
+	public function testWithAdditionalExtensions(AttributeCertificateInfo $aci) {
+		$aci = $aci->withAdditionalExtensions(
+			new AuthorityKeyIdentifierExtension(true, "test"));
+		$this->assertInstanceOf(AttributeCertificateInfo::class, $aci);
+		return $aci;
+	}
+
 	/**
 	 * @depends testCreateWithAll
 	 * @expectedException UnexpectedValueException