Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wiktionary] Relax case sensitivity a bit? #1214

Closed
dgw opened this issue Aug 8, 2017 · 1 comment
Closed

[wiktionary] Relax case sensitivity a bit? #1214

dgw opened this issue Aug 8, 2017 · 1 comment
Labels
Feature Tweak
Milestone
6.6.2

Comments

@dgw
Copy link
Member

dgw commented Aug 8, 2017

Looking up anything other than the exact capitalization in Wiktionary's database appears to fail. It might be worthwhile, for user experience, to always try the all-lowercase version of a query if no results are returned for it as entered.

That said, the MediaWiki API would allow querying automatically for several variants (using action=query&titles=variant1|Variant2|etc.) and then fetching the first one that exists for display, if making multiple requests is OK in the plugin.
@dgw dgw added this to the 6.6.0 milestone Mar 28, 2018
@dgw dgw modified the milestones: 6.6.0, 7.0.0 Dec 26, 2018
RustyBower added a commit to RustyBower/sopel that referenced this issue Jan 9, 2019
@RustyBower
wiktionary: fix query logix (see sopel-irc#1214)
e2f0104
@RustyBower RustyBower mentioned this issue Jan 9, 2019
Merged
@dgw dgw modified the milestones: 7.0.0, 6.6.2 Jan 31, 2019
RustyBower added a commit to RustyBower/sopel that referenced this issue Jan 31, 2019
@RustyBower
wiktionary: fix query logix (see sopel-irc#1214)
ee9fe88 
wiktionary: fixing .lower() logic
@dgw
Copy link
Member Author

dgw commented Feb 1, 2019

Calling this fixed by #1442.

@dgw dgw closed this as completed Feb 1, 2019
kwaaak pushed a commit to kwaaak/sopel that referenced this issue Mar 25, 2019
@RustyBower @kwaaak
wiktionary: fix query logix (see sopel-irc#1214)
3f9fc36 
wiktionary: fixing .lower() logic
@HumorBaby HumorBaby mentioned this issue Apr 25, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Tweak
Projects
None yet
Milestone
6.6.2
Development

No branches or pull requests
1 participant
@dgw