Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the disabling of repetition detection #1618

Closed
predakanga opened this issue May 21, 2019 · 5 comments · Fixed by #2320
Closed

Allow the disabling of repetition detection #1618

predakanga opened this issue May 21, 2019 · 5 comments · Fixed by #2320

Comments

@predakanga
Copy link

predakanga commented May 21, 2019

It would be useful for bot owners to be able to disable the repetition detection feature ("...").

We use Sopel primarily for devops and moderation, with modules which will often return repetitive answers (i.e. checking IPs or e-mails against blocklists), and thus far have had to fork Sopel to remove the "..." responses.

Other rate limits throughout Sopel are configurable (for instance, @rate); it would make sense to bring this in line with them, be it through a config option or a per-callable option to disable the feature.

Additionally, this would be very helpful for debugging modules.

@deathbybandaid
Copy link
Contributor

This is something I've been doing for the past few weeks with my dev bot. This would be a good addition to the new flood controls in #1518 ,,, config.core.message_loop_detection (Name TBD) seems like a good idea to me.

I do agree heavily with #1559 that the current state of the bot does NOT uniformly rate limit, and that these flood tweaks should filter through irc.bot.write and not Sopel.say.

I think #1518 and this should be added, but moreso in the form that @HumorBaby proposes in #1559 .

@dgw dgw modified the milestones: 7.0.0, 7.1.0 Nov 16, 2019
@dgw
Copy link
Member

dgw commented Nov 16, 2019

This is a "nice to have" that we can work on for 7.1. It won't add anything backward-incompatible, and so we don't need to find time to build and ship it in 7.0.

@dgw dgw modified the milestones: 7.1.0, 8.0.0 May 8, 2020
@predakanga
Copy link
Author

Just checking in on this - now that the custom flood protection patches have landed, I'd be happy to submit a PR for this (if welcome).

Would "repetition_filter" be an acceptable name for such a setting?

@dgw
Copy link
Member

dgw commented Oct 15, 2020

For a simple toggle, I'd name it something like limit_repetition (edit: or anti_looping). But if you're feeling ambitious and you think more knobs might be useful to override the hard-coded limits here, have at that. (I won't even start bikeshedding names for such settings unless you actually want to go that way, though! 😁)

@Exirel
Copy link
Contributor

Exirel commented Jul 14, 2022

@predakanga @deathbybandaid you can check the PR #2320 if you want. The code is pretty straightforward.

@dgw dgw closed this as completed in #2320 Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants