Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added key support for movie module #1203

Closed
wants to merge 1 commit into from

Conversation

nfearnley
Copy link
Contributor

As of May 8, 2017, the OMDb API has gone private. From now on it requires a paid API key to function.
This change adds support for an api key in the configuration file.
It also changes the module command examples so that they will not fail the CI tests if there is no API key.

@dgw
Copy link
Member

dgw commented Jun 11, 2017

Typically, the modules included in Sopel core do not require API keys. The most likely outcome of OMDb's new key requirement is that movie.py will become part of sopel-extras, or become a separate project elsewhere.

@nfearnley
Copy link
Contributor Author

I'll finishing cleaning up the code then, and setup a pull request to move it over to sopel-extras.

@dgw
Copy link
Member

dgw commented Mar 21, 2018

@nfearnley If you still have interest in working on this, I can now guarantee your PR will get looked at, whether you update this one (make sure to rebase on master and unignore the movie module from tests) or submit a PR to move the module into sopel-extras.

@nfearnley
Copy link
Contributor Author

Thanks. I'll take a look when I can.

@dgw
Copy link
Member

dgw commented Mar 22, 2018

There's some overlap with #1195, I just noticed, which appears to switch providers altogether. Just a heads-up about potential duplication of effort.

@dgw dgw added Feature Declined Requests that will not be implemented for technical or project direction reasons labels Jan 9, 2019
@dgw
Copy link
Member

dgw commented Jan 9, 2019

Not going to merge this. Unless/Until we can find a keyless API for movie/TV data, the module's going to just disappear from core.

@dgw dgw closed this Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Declined Requests that will not be implemented for technical or project direction reasons Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants