help: hotfix & small refactor #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced by #1459 (`dict.iteritems()` no longer exists in Python 3; only `dict.items()` does, with the same internal behavior as what `dict.iteritems()` did in Python 2)
There's no reason to define `help_prefix` as a global; just use `bot.config.core.help_prefix` everywhere instead and dump the global. There's also no reason to define the tracked settings in `setup()` instead of hard-coding them with the other constants. Between that, breaking up some long lines, and renaming stuff, this turned out to be a pretty big diff that "does nothing" from a user's point of view, but hopefully it will improve our results with tools like Scrutinizer (which flagged some of these "issues").
dgw
added
the
Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was fixing the
iteritems()py3 regression from #1459, I saw some other stuff that could use tweaking. Moved a bit of code around, and rewrote some comments—nbd really. Should be an easy ✔️