Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin: refactor silly nested if in hold_ground() #1880

Merged
merged 1 commit into from Jun 4, 2020
Merged

admin: refactor silly nested if in hold_ground() #1880

merged 1 commit into from Jun 4, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented May 31, 2020

Description

Just fixing a bit of silly code I noticed while looking for something else. This blatantly does nothing except make the code look less ridiculous. Even the "Tweak" label sounds too significant, lol.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Tweak label May 31, 2020
@dgw dgw added this to the 7.1.0 milestone May 31, 2020
@dgw dgw requested a review from a team May 31, 2020 17:34
@dgw dgw merged commit d850844 into master Jun 4, 2020
@dgw dgw deleted the silly-admin-code branch June 4, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgw @Exirel