Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pronouns: add 2-word pronouns aliases #2069

Merged
merged 1 commit into from May 24, 2021
Merged

pronouns: add 2-word pronouns aliases #2069

merged 1 commit into from May 24, 2021

Conversation

eliocamp
Copy link
Contributor

@eliocamp eliocamp commented May 17, 2021 •
edited

Description

Adds 2-word common pronoun sets.

Closes #2068

I didn't check it on my machine because it feels trivial. Let me know if you want me to test it properly.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Feature label May 17, 2021
@Exirel Exirel added this to the 7.1.0 milestone May 17, 2021
Exirel
Exirel requested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. The small nitpick is just a convention thing. For the merge commit, we'll see with @dgw how to squash that.

sopel/modules/pronouns.py Outdated Show resolved Hide resolved
@Exirel Exirel changed the title Adds 2-word pronouns aliases to pronoun module pronouns: adds 2-word pronouns aliases May 17, 2021
@half-duplex half-duplex mentioned this pull request May 17, 2021
Merged
4 tasks
dgw
dgw reviewed May 17, 2021
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Exirel I'd just rebase the branch to fixup the commit messages. However, though I haven't had a chance to look at it yet, it seems #2070 will supersede this.

sopel/modules/pronouns.py Outdated Show resolved Hide resolved
dgw
dgw approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll massage the commit history a bit, but it's basically ready to 🚢.

@eliocamp @Exirel @dgw
pronouns: add 2-word pronouns aliases
d8399a5 
Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
Co-authored-by: dgw <dgw@technobabbl.es>
@dgw dgw changed the title pronouns: adds 2-word pronouns aliases pronouns: add 2-word pronouns aliases May 24, 2021
@dgw dgw merged commit 31371b8 into sopel-irc:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Support 2-pronoun sets in the pronoun module
3 participants
@eliocamp @dgw @Exirel