tell: do not lstrip leading formatting #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a custom function to do this for now. We'll want to think about adding formatting-safe functions like this and what `choose` uses to Sopel's API, as core plugins surely aren't the only ones to run into such edge cases with leading/trailing formatting bytes.
dgw
added
Medium Priority
Bugfix
Exirel
approved these changes
Jul 25, 2021
dgw
added a commit
that referenced
this pull request
Aug 7, 2021
tell: do not lstrip leading formatting Cherry-picked from master: 8eee9ab
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin; bugfix to resolve #2157.
Also gets rid of the weird "lingering comma" behavior that that issue describes in passing, as a welcome side effect.
Checklist
make qa(runsmake qualityandmake test)Notes
Using a custom/bespoke function to do this for now. As mentioned in #2157, we probably should think about adding formatting-safe string-stripping functions like this and what
chooseuses to Sopel's API. Core plugins surely aren't the only ones to run into such edge cases with leading/trailing formatting bytes.