Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia: handle mobile links #2201

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

half-duplex
Copy link
Member

Description

< xnaas> TIL the Wikipedia plugin doesn't activate for mobile links
< xnaas> just standard url plugin output
< xnaas> rip in pieces

Previous:

< mal> https://en.m.wikipedia.org/wiki/1989_(Taylor_Swift_album)
< Sopel> [url] 1989 (Taylor Swift album) - Wikipedia | en.m.wikipedia.org

New (matches non-mobile behavior):

< mal> https://en.m.wikipedia.org/wiki/1989_(Taylor_Swift_album)
< Sopel> [wikipedia] 1989 (Taylor Swift album) | "1989 is the fifth studio album by American singer-songwriter Taylor Swift. It was released on October 27, 2014, by Big Machine Records. Following the release of her genre-spanning fourth studio album Red (2012), noted for pop hooks and electronic elements, the media questioned the validity of Swift's status as a country artist. Inspired by 1980s synth-pop to create a record that shifted her sound and image […]"

This does leave server="{lang}.m.wikipedia.org" for say_snippet()/etc, but the api seems to behave the same on both.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Oct 27, 2021
@ghost
Copy link

ghost commented Oct 27, 2021

I Wish You Would merge this, amirite. 😂

(It's a song on the album, for the unaware.)

Edit: If it's not merged, we're gonna have Bad Blood. 🤪

@dgw dgw added this to the 7.1.6 milestone Oct 31, 2021
@dgw dgw merged commit 5956333 into sopel-irc:master Nov 2, 2021
dgw added a commit that referenced this pull request Nov 2, 2021
wikipedia: handle mobile links

Corresponds to merge on master: 5956333
@half-duplex half-duplex deleted the wiki-mobile branch November 30, 2021 03:51
@half-duplex half-duplex restored the wiki-mobile branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants