adminchannel: rework topic-mask commands #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonus code style fix using `default` arg to `bot.db.get_channel_value()`
- `.tmask` without arguments now shows the current topic mask instead of clearing it. - `.showmask` command is redundant with the above, and has been removed. - `.cleartmask` is added to explicitly clear the topic mask.
dgw
added
Tweak
Bugfix
Exirel
approved these changes
Mar 18, 2024
|
Refactored to use subcommands. I kind of like this style, actually. The |
This was referenced Mar 19, 2024
dgw
force-pushed
the
adminchannel-tmask-none
branch
from
c0f3e35
to
e6a0a71
Compare
|
Last night, @half-duplex said in our IRC: "reading only the strings and decorators in 2601: lgtm" — and that puts to rest the earlier discussion about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.tmask getshows the current topic mask.tmaskwithout arguments assumes thegetsubcommand.tmask setnow sets the topic mask, and provides a usage hint if called without further arguments.tmask clearis added to explicitly clear the topic maskIn combination, the above should be sufficient to resolve #2596.
Checklist
make qa(runsmake lintandmake test)Notes
If no one minds adding this to 8.0.0 while the release notes are still under peer review, I'm happy to get it shipped sooner.
(Because it's modifying command behavior, if we don't ship this patch in 8.0.0, I believe the semver-appropriate thing to do would be to ship the first commit in 8.0.1 and hold the second for 8.1.0.)