Support QDQ format of Conv, ultraface model #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pzzzzz5142
changed the title
charlesxzb
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #51
Some issues:
Since there is no official implement of onnx-fashion rounding, so we have rounding error.
For some of the ops like relu, reshape, ppq doesn't provide scale and zero points. I infer these from the succeeding op.(maybe this is not a good choice)
Most of ops cannot read int8 weight when lowering to INT8. I only modified ConvOp to make it support int8 weight reading.
Only support the first format described in Support ONNX PPQ quantized model #51 for this is the only format ppq now officially support for symmetric quantization. See here.