This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
june new and run cli commands #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiajt
reviewed
May 3, 2024
| impl fmt::Display for CLIError { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self { | ||
| CLIError::New(_) => f.write_str("cannot to create new project"), |
There was a problem hiding this comment.
do we want to defer to the reason inside? Having it be this top level might be missing too much context.
| } | ||
| }; | ||
|
|
||
| match result { |
There was a problem hiding this comment.
I have a cheeky idea.
We already have an error reporter. We coooould use that and then make the source we're underlining the commandline and its args.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new cli subcommand for setting up June projects