Merge pull request #2384 from sophiemoustard/COM-3694

COM-3694: populate companies
sophiemoustard · Apr 23, 2024 · 400e8cd · 400e8cd
2 parents 24ecebe + 3d34831
commit 400e8cd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/helpers/holdings.js b/src/helpers/holdings.js
@@ -3,7 +3,10 @@ const Holding = require('../models/Holding');
 
 exports.create = async payload => Holding.create(payload);
 
-exports.list = async () => Holding.find({}, { _id: 1, name: 1 }).lean();
+exports.list = async () => Holding
+  .find({}, { _id: 1, name: 1 })
+  .populate({ path: 'companies' })
+  .lean();
 
 exports.update = async (holdingId, payload) => {
   if (payload.company) return CompanyHolding.create({ holding: holdingId, company: payload.company });

diff --git a/tests/unit/helpers/holdings.test.js b/tests/unit/helpers/holdings.test.js
@@ -34,15 +34,19 @@ describe('list', () => {
   });
 
   it('should return holdings', async () => {
-    const holdingList = [{ _id: new ObjectId(), name: 'Holding' }];
-    find.returns(SinonMongoose.stubChainedQueries(holdingList, ['lean']));
+    const holdingList = [{ _id: new ObjectId(), name: 'Holding', companies: [new ObjectId(), new ObjectId()] }];
+    find.returns(SinonMongoose.stubChainedQueries(holdingList));
 
     const result = await HoldingHelper.list();
 
     expect(result).toEqual(holdingList);
     SinonMongoose.calledOnceWithExactly(
       find,
-      [{ query: 'find', args: [{}, { _id: 1, name: 1 }] }, { query: 'lean', args: [] }]
+      [
+        { query: 'find', args: [{}, { _id: 1, name: 1 }] },
+        { query: 'populate', args: [{ path: 'companies' }] },
+        { query: 'lean', args: [] },
+      ]
     );
   });
 });