COM-3719 - select field + remove useless populate

sophiemoustard · Jun 18, 2024 · 6492456 · 6492456
1 parent 6374a1b
commit 6492456
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/helpers/questionnaireHistories.js b/src/helpers/questionnaireHistories.js
@@ -56,7 +56,9 @@ exports.updateQuestionnaireHistory = async (questionnaireHistoryId, payload) =>
   let setFields = { isValidated: true, ...(trainerComment && { trainerComment }) };
   if (trainerAnswers.some(a => a.answer)) {
     const trainerAnswersByCard = keyBy(trainerAnswers, 'card');
-    const questionnaireHistory = await QuestionnaireHistory.findOne({ _id: questionnaireHistoryId }).lean();
+    const questionnaireHistory = await QuestionnaireHistory
+      .findOne({ _id: questionnaireHistoryId }, { questionnaireAnswersList: 1 })
+      .lean();
 
     const questionnaireAnswersList = [];
     for (const bddAnswer of questionnaireHistory.questionnaireAnswersList) {

diff --git a/src/routes/preHandlers/questionnaireHistories.js b/src/routes/preHandlers/questionnaireHistories.js
@@ -42,9 +42,7 @@ exports.authorizeQuestionnaireHistoryUpdate = async (req) => {
 
   const cardIds = trainerAnswers.map(answer => answer.card);
   const questionnaire = await Questionnaire
-    .findOne({ _id: questionnaireHistory.questionnaire, cards: { $in: cardIds } })
-    .populate({ path: 'cards', select: 'labels' })
-    .lean();
+    .countDocuments({ _id: questionnaireHistory.questionnaire, cards: { $in: cardIds } });
   if (!questionnaire) throw Boom.notFound();
 
   const answersHasGoodLength = trainerAnswers.length === questionnaireHistory.questionnaireAnswersList.length;

diff --git a/tests/unit/helpers/questionnaireHistories.test.js b/tests/unit/helpers/questionnaireHistories.test.js
@@ -366,7 +366,10 @@ describe('updateQuestionnaireHistory', () => {
 
     SinonMongoose.calledOnceWithExactly(
       findOne,
-      [{ query: 'findOne', args: [{ _id: questionnaireHistoryId }] }, { query: 'lean' }]
+      [
+        { query: 'findOne', args: [{ _id: questionnaireHistoryId }, { questionnaireAnswersList: 1 }] },
+        { query: 'lean' },
+      ]
     );
     sinon.assert.calledWithExactly(
       updateOne,