Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/bump-kotlin-2] Kotlin 2.0으로 Migration #706

Merged
merged 19 commits into from
Jun 8, 2024

Conversation

l2hyunwoo
Copy link
Member

@l2hyunwoo l2hyunwoo commented May 22, 2024

What is this issue?

  • 전반적인 빌드 속도 향상 및 신기능 추가가 기대되기에 신속하게 Kotlin 2.0.0 마이그레이션 준비 진행하고자 합니다.

Reference

  • Compose 버전관리는 앞으로 composeCompiler(Build Logic에선 ComposeCompilerGradlePluginExtension)에서 관리합니다.

Known Issue

Kotlin 2.0 마이그레이션 시 발생하는 에러 공유드립니다.

사이드 프로젝트에서 Kotlin 2.0/ksp 2.0.0-1.0.21로 버전 마이그레이션 치고 있는데 빌드 시 :app:checkDebugDuplicateClass 프로세스에> 서 Duplicate class found 에러가 뜹니다. Clean Build/Invalidate Cache 모두 적용하였음에도 에러가 뜨네요.

그리고 :app:mergeDebugJavaResource 프로세스에도 RelativePath kotlin//.kotlin_builtins 라는 파일이 중복된다는 에러가 뜨네요.

  • 버전: Kotlin 2.0.0/ksp 2.0.0-1.0.21
  • 실행 환경: Android Studio Koala Beta 2

해결: build-logic>convention>build.gradle.kts에서 추가되었던 compose gradle plugin 의존성을 제거

@l2hyunwoo l2hyunwoo self-assigned this May 22, 2024
@l2hyunwoo l2hyunwoo requested a review from a team as a code owner May 22, 2024 02:03
Copy link

height bot commented May 22, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 23, 2024
@l2hyunwoo l2hyunwoo marked this pull request as draft May 23, 2024 14:57
@l2hyunwoo
Copy link
Member Author

@chattymin @giovannijunseokim 안정성때문에 해당 PR은 일정기간 텀을 둔 이후 머지를 할 예정입니다.

@l2hyunwoo l2hyunwoo force-pushed the feature/bump-kotlin-2 branch 3 times, most recently from 7e04281 to ee62bec Compare May 28, 2024 02:17
@l2hyunwoo l2hyunwoo force-pushed the feature/bump-kotlin-2 branch 3 times, most recently from 3414e03 to cf8261f Compare June 2, 2024 04:42
@l2hyunwoo l2hyunwoo marked this pull request as ready for review June 5, 2024 00:21
@l2hyunwoo
Copy link
Member Author

@chattymin @giovannijunseokim 이 PR Youtrack에서 이슈 Kotlin 2.0 관련 이슈 지속해서 트래킹하고 있는데 발견되지 않아서 오늘 이내에 머지하도록 하겠습니다.

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신기술 적용 감사합니다! 👍

@l2hyunwoo l2hyunwoo merged commit d00fd98 into develop Jun 8, 2024
1 check failed
@l2hyunwoo l2hyunwoo deleted the feature/bump-kotlin-2 branch June 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants