Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#263 [CHORE] Legacy Url 관련 코드 삭제 #264

Merged
merged 2 commits into from
Jun 16, 2024
Merged

#263 [CHORE] Legacy Url 관련 코드 삭제 #264

merged 2 commits into from
Jun 16, 2024

Conversation

yeseul106
Copy link
Member

@yeseul106 yeseul106 commented Jun 4, 2024 •
edited
Loading

Related Issue 🚀

Work Description ✏️

  • 클라이언트의 배포 도메인 변경에 따라 legacy 주소 관련 코드를 제거했습니다.
  • 깃허브 액션 시크릿키 변경 해두었습니다.

PR Point 📸

@yeseul106 yeseul106 added the chore 잡일 label Jun 4, 2024
@yeseul106 yeseul106 self-assigned this Jun 4, 2024
@height Height
Copy link

height bot commented Jun 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@height Height
Copy link

height bot commented Jun 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

3 similar comments
@height Height
Copy link

height bot commented Jun 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@height Height
Copy link

height bot commented Jun 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@height Height
Copy link

height bot commented Jun 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

KWY0218
KWY0218 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@KWY0218 KWY0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업 감사합니다 ~ !

KWY0218
KWY0218 reviewed Jun 6, 2024
View reviewed changes
operation-domain/src/main/java/org/sopt/makers/operation/auth/domain/TeamOAuthInfo.java

@Entity
@Table(name = "team_oauth_info")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!! 😄

@KWY0218 KWY0218 added this pull request to the merge queue Jun 16, 2024
Merged via the queue into develop with commit 2aaceef Jun 16, 2024
1 check passed
@KWY0218 KWY0218 deleted the chore/#263 branch June 16, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KWY0218 KWY0218 KWY0218 approved these changes

@yummygyudon yummygyudon Awaiting requested review from yummygyudon

Assignees

@yeseul106 yeseul106

Labels
chore 잡일 size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] security legacy 코드 삭제
2 participants
@yeseul106 @KWY0218