Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/swap transfer batch additional fee #325

Merged
merged 11 commits into from
Mar 15, 2023
Merged

Feature/swap transfer batch additional fee #325

merged 11 commits into from
Mar 15, 2023

Conversation

pakrentos
Copy link
Contributor

@pakrentos pakrentos commented Mar 10, 2023 •
edited

Changes

  • Added ADAR commission to swap_transfer_batch
  • Refactored swap_transfer_batch
  • Refactored tests
  • Changed ratio of reserves in liquidity_source mock (part of the tests' fix)

Linked to #323

@pakrentos pakrentos mentioned this pull request Mar 10, 2023
Closed
@pakrentos pakrentos requested a review from vovac12 March 13, 2023 10:40
@pakrentos pakrentos marked this pull request as ready for review March 13, 2023 10:40
@pakrentos pakrentos requested review from Harrm and wer1st March 13, 2023 10:41
@pakrentos pakrentos requested a review from wer1st March 14, 2023 09:01
vovac12
vovac12 reviewed Mar 14, 2023
View reviewed changes
pallets/liquidity-proxy/src/lib.rs Outdated Show resolved Hide resolved
pallets/liquidity-proxy/src/lib.rs Outdated Show resolved Hide resolved
pallets/liquidity-proxy/src/lib.rs Outdated Show resolved Hide resolved
@pakrentos pakrentos requested a review from vovac12 March 14, 2023 16:52
@pakrentos pakrentos merged commit f96497d into develop Mar 15, 2023
@pakrentos pakrentos deleted the feature/swap-transfer-batch-additional-fee branch March 15, 2023 13:41
@pakrentos pakrentos mentioned this pull request Mar 16, 2023
Closed
6 tasks
@bgodlin bgodlin mentioned this pull request Apr 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wer1st wer1st wer1st approved these changes

@vovac12 vovac12 vovac12 approved these changes

@Harrm Harrm Awaiting requested review from Harrm

@stefashkaa stefashkaa Awaiting requested review from stefashkaa

@Nikita-Polyakov Nikita-Polyakov Awaiting requested review from Nikita-Polyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pakrentos @wer1st @vovac12