Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Book: execute market order #454

Merged
merged 25 commits into from
May 25, 2023
Merged

Conversation

wer1st
Copy link
Contributor

@wer1st wer1st commented May 19, 2023

No description provided.

wer1st added 22 commits May 10, 2023 14:24
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
…sora2-network into 280-281-execute-market-order
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
…sora2-network into 280-281-execute-market-order
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st wer1st added this to the OrderBook milestone May 19, 2023
@wer1st wer1st requested review from bragov4ik and vovac12 May 19, 2023 17:18
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Copy link
Contributor

@bragov4ik bragov4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Had to concentrate to understand order execution ;)

pallets/order-book/src/limit_order.rs Show resolved Hide resolved
pallets/order-book/src/limit_order.rs Outdated Show resolved Hide resolved
pallets/order-book/src/order_book.rs Show resolved Hide resolved
pallets/order-book/src/order_book.rs Show resolved Hide resolved
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Copy link
Contributor

@vovac12 vovac12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great)

@wer1st wer1st merged commit 79927a7 into develop May 25, 2023
3 checks passed
@wer1st wer1st deleted the 280-281-execute-market-order branch May 25, 2023 09:40
@Tieumsan Tieumsan added the orderbook Task related to the orderbook project label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orderbook Task related to the orderbook project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants