Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALT: New smart split of liquidity #732

Merged
merged 44 commits into from
Feb 15, 2024
Merged

ALT: New smart split of liquidity #732

merged 44 commits into from
Feb 15, 2024

Conversation

wer1st
Copy link
Contributor

@wer1st wer1st commented Sep 19, 2023 •
edited

No description provided.

@wer1st
liquidity aggregator
079ebc9 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
Merge branch 'develop' of github.com:sora-xor/sora2-network into 447-…
e6356c0 
…remake-smart-split
@wer1st
liquidity aggregator update
358cb6d 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
Merge branch 'develop' of github.com:sora-xor/sora2-network into 447-…
3e4c333 
…remake-smart-split
@wer1st
Merge branch 'develop' of github.com:sora-xor/sora2-network into 447-…
1b42154 
…remake-smart-split
@wer1st
order book step quote
ab97c9a 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
pool-xyk step quote
311018d 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
xst step quote
793027b 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
tbc step quote
052aafd 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
vec
90a5e9c 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
new smart split
2493a49 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st wer1st added this to the 3.2.0 - OrderBook milestone Sep 19, 2023
@wer1st
fix tests
ed58063 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
make samples count a config param
936d40a 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
fees
425f091 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
bragov4ik
bragov4ik reviewed Sep 21, 2023
View reviewed changes
pallets/liquidity-proxy/src/lib.rs Show resolved Hide resolved
pallets/liquidity-proxy/src/lib.rs Show resolved Hide resolved
pallets/liquidity-proxy/src/liquidity_aggregator.rs Show resolved Hide resolved
pallets/multicollateral-bonding-curve-pool/src/lib.rs Show resolved Hide resolved
pallets/order-book/src/lib.rs Outdated Show resolved Hide resolved
pallets/order-book/src/order_book.rs Show resolved Hide resolved
pallets/xst/src/lib.rs Show resolved Hide resolved
pallets/xst/src/lib.rs Outdated Show resolved Hide resolved
@wer1st
rewards
ff1018a 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
fix xst fee
c8630ec 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
bragov4ik
bragov4ik reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@bragov4ik bragov4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@wer1st
step quote benchmarks
f2d4fc3 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
apply comments
af34d59 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
use new smart split
46975ce 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
bragov4ik
bragov4ik suggested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@bragov4ik bragov4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only bit that bothers me is zero weight, going to approve after discussing/fixing it

pallets/multicollateral-bonding-curve-pool/src/lib.rs Show resolved Hide resolved
pallets/xst/src/lib.rs Show resolved Hide resolved
@wer1st wer1st modified the milestones: 3.2.0 - OrderBook, 3.3.0 - ALT Sep 26, 2023
@wer1st wer1st changed the title New smart split of liquidity ALT: New smart split of liquidity Sep 29, 2023
Nikita Zaporozhets and others added 6 commits October 9, 2023 12:49
test predev build
4e72bbc 
Signed-off-by: Nikita Zaporozhets <zaporozhets@soramitsu.co.jp>
Merge branch '447-remake-smart-split' of https://github.com/sora-xor/…
20037a3 
…sora2-network into 447-remake-smart-split
fix operator
0eb8ca3 
Signed-off-by: Nikita Zaporozhets <zaporozhets@soramitsu.co.jp>
@wer1st
merge develop & fix
35d2d12 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
update tag comment
446b243 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
fix weights & tests
0ee5c06 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
fix benchmarks
4bd0820 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

vovac12
vovac12 reviewed Feb 13, 2024
View reviewed changes
pallets/liquidity-proxy/src/lib.rs Show resolved Hide resolved
pallets/liquidity-proxy/src/lib.rs Outdated Show resolved Hide resolved
@wer1st
apply comments
df86e9e 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st wer1st requested a review from vovac12 February 13, 2024 08:28
@wer1st
minor
7b4fae2 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
Merge branch 'develop' into 447-remake-smart-split
ca5aac3
@wer1st wer1st merged commit 04c02f3 into develop Feb 15, 2024
5 checks passed
@wer1st wer1st deleted the 447-remake-smart-split branch February 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bragov4ik bragov4ik bragov4ik approved these changes

@vovac12 vovac12 vovac12 approved these changes

@stefashkaa stefashkaa Awaiting requested review from stefashkaa

@Nikita-Polyakov Nikita-Polyakov Awaiting requested review from Nikita-Polyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 - ALT
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wer1st @bragov4ik @vovac12