Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderBook: market maker network fee #762

Merged
merged 11 commits into from
Oct 5, 2023
Merged

OrderBook: market maker network fee #762

merged 11 commits into from
Oct 5, 2023

Conversation

wer1st
Copy link
Contributor

@wer1st wer1st commented Oct 4, 2023

Introduce the custom reduced network fee for maket makers.
place_limit_order the following network fees:

  • reduced fee if the limit order successfully placed
  • regular fee if some error occurs
  • regular fee if the limit order was converted into a market order

@wer1st
fee calculator
eb6da53 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
delete comments
581802e 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
use fee calculator
65babfd 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
Merge branch 'develop' of github.com:sora-xor/sora2-network into 348-…
d69314b 
…order-book-fee
@wer1st
tests
a14bf8b 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
apply the cross-spread case
bfc8982 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
update approach
6dde7ff 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st
Merge branch 'develop' of github.com:sora-xor/sora2-network into 348-…
7a2947c 
…order-book-fee
@wer1st wer1st added this to the 3.2.0 - OrderBook milestone Oct 4, 2023
@wer1st wer1st changed the title OrderBook: market maket network fee OrderBook: market maker network fee Oct 4, 2023
bragov4ik
bragov4ik suggested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@bragov4ik bragov4ik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about computation error part
LGTM other than this

pallets/order-book/src/fee_calculator.rs Show resolved Hide resolved
pallets/order-book/src/fee_calculator.rs Show resolved Hide resolved
pallets/order-book/src/fee_calculator.rs Show resolved Hide resolved
@wer1st wer1st requested a review from bragov4ik October 4, 2023 15:36
@wer1st
apply comments
3c14c4c 
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st wer1st requested a review from vovac12 October 4, 2023 19:24
@wer1st wer1st merged commit 399e016 into develop Oct 5, 2023
3 checks passed
@wer1st wer1st deleted the 348-order-book-fee branch October 5, 2023 14:21
@Tieumsan Tieumsan added the orderbook Task related to the orderbook project label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bragov4ik bragov4ik bragov4ik approved these changes

@vovac12 vovac12 vovac12 approved these changes

@stefashkaa stefashkaa Awaiting requested review from stefashkaa

@Nikita-Polyakov Nikita-Polyakov Awaiting requested review from Nikita-Polyakov

Assignees
No one assigned
Labels
orderbook Task related to the orderbook project
Projects
None yet
Milestone
3.2.0 - OrderBook v1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wer1st @bragov4ik @vovac12 @Tieumsan