Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicollateral bonding curve pool initialization #919

Merged
merged 244 commits into from
Mar 7, 2024
Merged

Multicollateral bonding curve pool initialization #919

merged 244 commits into from
Mar 7, 2024

Conversation

bragov4ik
Copy link
Contributor

@bragov4ik bragov4ik commented Feb 28, 2024 •
edited

  • Add initialization for mcbc source akin to other sources
  • Better test organization in qa-tools
  • Remove redundant type parameter in qa-tools pallet (whitelist capacity; whitelist was removed previously)
  • Small improvements of qa-tools (readability, code deduplication)

@bragov4ik
separate approx_eq logic into a function
4543ea3
@bragov4ik
add othere kinds of approx equal fns
ef1230e
@bragov4ik
use weak inequalities as tolerance borders should be included
18e77bf
@bragov4ik
use only Fixed and only one comparison call in approx_eq
e555240
@bragov4ik
convert to Fixed in approx_eq_abs macro
048e49a
@bragov4ik
approx_eq errors + some tests
b72e3a2
@bragov4ik
add corresponding macros
ad398a8
@bragov4ik
utilize fixed constants
4da1225
@bragov4ik
test for exact numbers
9bfd5a5
@bragov4ik
abs tolerance match test
582f753
@bragov4ik
reusable and deduplicated test cases
ccc447a
@bragov4ik
similar test for are_approx_eq_abs
d010582
@bragov4ik
similar test for are_approx_eq_rel
89b530c
@bragov4ik
reformat tolerances in comments
2b1efdb
@bragov4ik
more equal numbers tests
fd6c985
@bragov4ik
relative tolerance test
037c231
@bragov4ik
fix comments/values in tests
14a0e90
@bragov4ik
fix tests
6a57244
@bragov4ik
test both matches & no matches
eb91620
@bragov4ik
allow trailing comma in macros
c800088
@bragov4ik
test and fix macros
aed5e4a
@bragov4ik
fix tests and remove dbgs
9721a12
@bragov4ik
clippy fix
4d1f21f
@bragov4ik
convert between divisible/indivisible balanceunit
491e62d
@bragov4ik
xyk init
02865bf
@bragov4ik
comments
5051d88
@bragov4ik
improve code order
3798f67
@bragov4ik
improve into_divisible
8dfdea9
@bragov4ik
fix option/result usage
8897636
@bragov4ik
init xyk extrinsic + test
975ebf7
@bragov4ik bragov4ik linked an issue Feb 28, 2024 that may be closed by this pull request
QA Tools: initialize liquidity source #749
Closed
@bragov4ik bragov4ik added feature Adding support for a new feature in the network ShouldHave Important and adds significant value to the release, but not vital labels Feb 28, 2024
wer1st
wer1st reviewed Mar 5, 2024
View reviewed changes
pallets/qa-tools/Cargo.toml Outdated Show resolved Hide resolved
pallets/qa-tools/src/lib.rs Outdated Show resolved Hide resolved
bragov4ik
bragov4ik commented Mar 5, 2024
View reviewed changes
pallets/qa-tools/src/lib.rs Outdated Show resolved Hide resolved
Base automatically changed from 749-initialize-liquidity to develop March 6, 2024 12:38
@bragov4ik bragov4ik requested a review from wer1st March 6, 2024 13:26
@bragov4ik bragov4ik merged commit a5dc5ce into develop Mar 7, 2024
6 checks passed
@bragov4ik bragov4ik deleted the 749-initialize-mcbc branch March 7, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexey-N-Chernyshov Alexey-N-Chernyshov Alexey-N-Chernyshov approved these changes

@wer1st wer1st wer1st approved these changes

@vovac12 vovac12 Awaiting requested review from vovac12

@N1ghtStorm N1ghtStorm Awaiting requested review from N1ghtStorm

@stefashkaa stefashkaa Awaiting requested review from stefashkaa

@Nikita-Polyakov Nikita-Polyakov Awaiting requested review from Nikita-Polyakov

Assignees

@bragov4ik bragov4ik

Labels
feature Adding support for a new feature in the network ShouldHave Important and adds significant value to the release, but not vital
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QA Tools: initialize liquidity source
3 participants
@bragov4ik @Alexey-N-Chernyshov @wer1st