Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --size and --margin of encode command #311

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

sorairolake
Copy link
Owner

@sorairolake sorairolake commented Dec 17, 2023

Description

Change these to optional arguments and remove the default values.

  • The default value of the module size for UTF-8 string is preferably 1, otherwise 8 is preferred12.
  • The default value of the margin for Micro QR code is preferably 2, otherwise 4 is preferred34.

Closes #

Additional context

Checklist

Footnotes

  1. https://docs.rs/qrcode/0.13.0/src/qrcode/render/unicode.rs.html#20

  2. https://docs.rs/qrcode/0.13.0/src/qrcode/render/mod.rs.html#26

  3. https://docs.rs/qrcode/0.13.0/src/qrcode/lib.rs.html#250

  4. qrencode --help

Change these to optional arguments and remove the default values.
@sorairolake sorairolake merged commit 2f33684 into develop Dec 17, 2023
19 checks passed
@sorairolake sorairolake deleted the change-options-to-optional branch December 17, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant