FLW-1106 Calculate completion time for targetEra #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ef1rspb
commented
Jul 27, 2021
ef1rspb
commented
Codecov Report
@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
+ Coverage 31.43% 34.68% +3.24%
===========================================
Files 462 524 +62
Lines 19656 23967 +4311
===========================================
+ Hits 6179 8312 +2133
- Misses 13477 15655 +2178
|
ERussel
reviewed
Jul 27, 2021
| @@ -110,13 +110,14 @@ final class StakingPayoutViewModelFactory: StakingPayoutViewModelFactoryProtocol | |||
| activeEra: EraIndex, | |||
| payoutEra: EraIndex, | |||
| historyDepth: UInt32, | |||
| eraCompletionTime: TimeInterval?, | |||
| eraCountdown: EraCountdown?, | |||
| locale: Locale | |||
| ) -> NSAttributedString { | |||
| let eraDistance = historyDepth - (activeEra - payoutEra) | |||
| let daysLeft = Int(eraDistance) / chain.erasPerDay | |||
There was a problem hiding this comment.
Probably now we don't need erasPerDay because we can pass target era to eraCompletionTime
ERussel
reviewed
Jul 27, 2021
| @@ -179,13 +179,14 @@ struct StakingBalanceViewModelFactory: StakingBalanceViewModelFactoryProtocol { | |||
| private func timeLeftAttributedString( | |||
| activeEra: EraIndex, | |||
| unbondingEra: EraIndex, | |||
| eraCompletionTime: TimeInterval?, | |||
| eraCountdown: EraCountdown?, | |||
| locale: Locale | |||
| ) -> NSAttributedString { | |||
| let eraDistance = unbondingEra - activeEra | |||
| let daysLeft = Int(eraDistance) / chain.erasPerDay | |||
There was a problem hiding this comment.
Probably now we don't need erasPerDay because we can pass target era to eraCompletionTime.
ERussel
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.