Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby27: hoisted out f_rest_marg #3314

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 22, 2020

Motivation

Grammar refactoring tracking whitequark/parser#594, no visible change.

Test plan

See included automated tests.

This commit tracks upstream commit ruby/ruby@78a8888.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar requested a review from a team as a code owner July 22, 2020 21:12
@Morriar Morriar requested review from elliottt and removed request for a team July 22, 2020 21:12
@Morriar Morriar mentioned this pull request Jul 22, 2020
@elliottt
Copy link
Contributor

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build result here:

https://go/builds/bui_Hhi1XGg4dtOsIb

@elliottt
Copy link
Contributor

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build result here:

https://go/builds/bui_Hhi9yZZitcK9kN

Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elliottt elliottt merged commit 88aec85 into sorbet:master Jul 24, 2020
@Morriar Morriar deleted the at-ruby27-f_rest_marg branch July 27, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants