Add type definition Enumerable#tally and Module#const_source_location #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jez
reviewed
Oct 17, 2020
jez
reviewed
Oct 17, 2020
jez
approved these changes
Oct 17, 2020
ohbarye
deleted the
add-type-definition-tally-and-const_source_location
branch
|
Thanks for your review and for fixing my mistakes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added type definitions for the methods below.
Enumerable#tallyModule#const_source_locationMotivation
By adding those definitions, Sorbet would get a bit more useful in Ruby 2.7.
Related: #2390
Test plan
I added test data and confirmed that
bazel test test --config=dbgpassed.