Make bare Class an error
#6983
Merged
Make bare Class an error
#6983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Merged
jez
force-pushed
the
jez-t-class-error
branch
2 times, most recently
from
f4deb7e
to
5910569
Compare
jez
force-pushed
the
jez-t-class-error
branch
4 times, most recently
from
8af1421
to
9488501
Compare
jez
force-pushed
the
jez-t-class-error
branch
2 times, most recently
from
b573bbe
to
5c9b638
Compare
If you need to silence this error temporarily for a migration or
compatibility reasons, you can pass this command line flag:
--suppress-error-code=5046
This will suppress *all* bare stdlib generic errors, so things like
`Array` and `Hash` will also not be reported as an error. Thus using
this flag should be considered only a temporary migration mechanism.
Other temporary migration techniques:
- Downgrade any files with these errors to `# typed: true`, and
re-upgrade them to `# typed: strict` once all bare `Class` errors have
been fixed in the file.
- Downgrade Sorbet back to the version before this error started to be
reported. That version treats `T::Class` as valid type syntax, but
does not report an error for bare `Class` usage.
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_NuhREj4kpTW4r4 |
neilparikh
approved these changes
May 17, 2023
Yep. |
egiurleo
added a commit
to Shopify/ruby-lsp
that referenced
this pull request
May 22, 2023
Sorbet introduced a change to raise an error when `Class` is used as a type without generic type parameters: sorbet/sorbet#6983 This commit converts two instances of the `Class` type to `T::Class[T.anything]`
egiurleo
added a commit
to Shopify/tapioca
that referenced
this pull request
May 24, 2023
Sorbet has made using Class without specifying a generic type argument an error (sorbet/sorbet#6983), so this commit fixes the existing instances of this pattern in Tapioca.
egiurleo
added a commit
to Shopify/tapioca
that referenced
this pull request
May 25, 2023
Sorbet has made `Class` a generic type, so using `Class` on its own in type signatures now raises an exception (sorbet/sorbet#6983).
andyw8
pushed a commit
to Shopify/tapioca
that referenced
this pull request
Jun 6, 2023
Sorbet has made `Class` a generic type, so using `Class` on its own in type signatures now raises an exception (sorbet/sorbet#6983).
ilyailya
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Make bare `Class` an error
If you need to silence this error temporarily for a migration or
compatibility reasons, you can pass this command line flag:
--suppress-error-code=5046
This will suppress *all* bare stdlib generic errors, so things like
`Array` and `Hash` will also not be reported as an error. Thus using
this flag should be considered only a temporary migration mechanism.
Other temporary migration techniques:
- Downgrade any files with these errors to `# typed: true`, and
re-upgrade them to `# typed: strict` once all bare `Class` errors have
been fixed in the file.
- Downgrade Sorbet back to the version before this error started to be
reported. That version treats `T::Class` as valid type syntax, but
does not report an error for bare `Class` usage.
* Fix the bare `Class` in our payload
* Fix existing tests
* Capture master behavior for new test
* Show test's new behavior
* Also fix ClassNew rewriter
* Fix test
* Update cli exp
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to users
If you need to silence this error temporarily for a migration or
compatibility reasons, you can pass this command line flag:
This will suppress all bare stdlib generic errors, so things like
ArrayandHashwill also not be reported as an error. Thus usingthis flag should be considered only a temporary migration mechanism.
Other temporary migration techniques:
Downgrade any files with these errors to
# typed: true, andre-upgrade them to
# typed: strictonce all bareClasserrors havebeen fixed in the file.
Downgrade Sorbet back to the version before this error started to be
reported. That version treats
T::Classas valid type syntax, butdoes not report an error for bare
Classusage.Motivation
This closes a follow-up action item from #6781.
Test plan
See included automated tests.
Review by commit to see the changes to the tests.