Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and release on linux-aarch64 #7718

Merged
merged 1 commit into from Feb 23, 2024
Merged

Build and release on linux-aarch64 #7718

merged 1 commit into from Feb 23, 2024

Conversation

DazWorrall
Copy link
Contributor

@DazWorrall DazWorrall commented Feb 22, 2024

Closes #4119

Build and release on aarch64 linux, uses a dedicated target so the x86_64 build keeps its optimisations.

@DazWorrall DazWorrall changed the title Dw arm64 wip WIP linux-aarch64 builds Feb 22, 2024
@DazWorrall DazWorrall changed the title WIP linux-aarch64 builds Build and release on linux-aarch64 Feb 23, 2024
@@ -107,6 +107,9 @@ build:untyped-blame --copt=-DTRACK_UNTYPED_BLAME_MODE
# harden: mark relocation sections read-only
build:release-linux --linkopt=-Wl,-z,relro,-z,now
build:release-linux --config=lto-linux --config=release-common
# Separate config for aarch64, so x86_64 can be differently optimized
build:release-linux-aarch64 --linkopt=-Wl,-z,relro,-z,now
build:release-linux-aarch64 --config=lto-linux --config=release-common
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is perhaps some DRYing up to do here, but let's get the new builds right first and not touch the existing release-linux config.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I'm going to take a pass over these options.

@DazWorrall DazWorrall marked this pull request as ready for review February 23, 2024 18:19
@DazWorrall DazWorrall requested a review from a team as a code owner February 23, 2024 18:20
@DazWorrall DazWorrall requested review from neilparikh and removed request for a team February 23, 2024 18:20
@jez jez merged commit ad6c216 into sorbet:master Feb 23, 2024
16 checks passed
@DazWorrall DazWorrall deleted the dw-arm64-wip branch February 23, 2024 20:46
ZhongRuoyu added a commit to ZhongRuoyu/homebrew-aarch64-linux that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Ubuntu Linux on ARM64 (aarch64)
2 participants