New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer lambda return types #7741

Closed

jez wants to merge 4 commits into jez-block-arity-overload from jez-proc-return

Collaborator

jez commented Mar 1, 2024

Motivation

Partial fix for #3914
Partial fix for #4149

Test plan

@jez write tests

Collaborator Author

jez commented Mar 1, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_PewZ5mTLBbaHfA
→ https://go/builds/bui_PewZb67f04mNoS
→ https://go/builds/bui_PewZQ4Ia9XSrcA

jez mentioned this pull request

Block arity isn't considered for overloads #7743

Open

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

05007af

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez mentioned this pull request

Teach guessOverload to respect block arity #7859

Draft

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

8303fcb

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

271df4f

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

585ca7b

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

422bf0e

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

e4e5c00

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

90a40c9

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

9d53317

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

821d830

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

jez force-pushed the jez-proc-return branch from 6985bb3 to 473d53c Compare

June 28, 2024 05:31

jez changed the base branch from master to jez-block-arity-overload

June 28, 2024 05:32

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

a9cde81

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

Collaborator Author

jez commented Jun 28, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_QNI1teTRhqvEFS
→ https://go/builds/bui_QNI1BtEIXvzys1
→ https://go/builds/bui_QNI1OU4ztyUAma

jez force-pushed the jez-proc-return branch from 473d53c to 5140ca8 Compare

June 28, 2024 05:39

jez added 3 commits

June 27, 2024 23:23


          Infer lambda return types

393b5cb

Partial fix for #3914
Partial fix for #4149


          Add a rudimentary test


          bazel run //rbi:update_procs_rbi

559a14a

jez force-pushed the jez-proc-return branch from 5140ca8 to 559a14a Compare

June 28, 2024 06:25

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

07bd03b

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

Collaborator Author

jez commented Jun 28, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_QNIsi6nOzz6NRr
→ https://go/builds/bui_QNIsujmT264MAm
→ https://go/builds/bui_QNIsyXSHZXJTIP

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

6b66f5c

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

Collaborator Author

jez commented Jun 28, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_QNIzBxeyA7Zv1r
→ https://go/builds/bui_QNIzPpyAxTpTpg
→ https://go/builds/bui_QNIzkrsvEpiYqW


          Add a base case if none of the T.proc types apply

84f1fae

jez added a commit that referenced this pull request


          Teach guessOverload to respect block arity

89932cf

Sometimes it's useful to be able to use the arity of the block to guess
an overload.

This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.

This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
`Kernel#lambda` blocks by codegenerating overloaded signatures.

Collaborator Author

jez commented Jun 28, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_QNJO1spvdG0G3M
→ https://go/builds/bui_QNJOEhzUoYY9hE
→ https://go/builds/bui_QNJOIrw9Kj5oHB

jez mentioned this pull request

Infer lambda return types #8011

Merged

1 task

Collaborator Author

jez commented Jun 29, 2024

Closing in favor of #8011

jez closed this

jez deleted the jez-proc-return branch

July 1, 2024 20:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment