Remove eval and use replace instead

sorenlouv · May 8, 2019 · fe109c0 · fe109c0
1 parent 0864f16
commit fe109c0
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/steps/doBackportVersions.ts b/src/steps/doBackportVersions.ts
@@ -180,14 +180,15 @@ function getPullRequestTitle(
   commits: Commit[],
   prTitle: string
 ) {
-  // @ts-ignore
-  const commitMessages = commits // eslint-disable-line @typescript-eslint/no-unused-vars
+  const commitMessages = commits
     .map(commit => commit.message)
     .join(' | ')
     .slice(0, 200);
 
   // prTitle could include baseBranch or commitMessages in template literal
-  return eval('`' + prTitle + '`');
+  return prTitle
+    .replace('${baseBranch}', baseBranch)
+    .replace('${commitMessages}', commitMessages);
 }
 
 export function getPullRequestPayload(