Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix backport PRs with [<branch>] rather than [backport] #7

Closed
epixa opened this issue Oct 24, 2017 · 2 comments
Closed

Prefix backport PRs with [<branch>] rather than [backport] #7

epixa opened this issue Oct 24, 2017 · 2 comments

Comments

@epixa
Copy link

epixa commented Oct 24, 2017

Having some sort of meaningful indication on a PR that it is a backport is helpful, but it doesn't necessarily need to be the word "backport" in the title. The convention of putting the target backport branch as a prefix on the backport PR title would still be recognized by people using this tool frequently, and the backport label could be the thing that says the word "backport" in case people want that.

Using the branch prefix really helps with auditing PRs to ensure that they were properly backported since you'd have all of the necessary information you need about the PRs right in the linkbacks in the original PR.

For example, these linked backport PRs would be much more useful if they instead began with their target branch:

screen shot 2017-10-24 at 4 52 18 pm

@epixa
Copy link
Author

epixa commented Oct 24, 2017

This is how it would look in the PR list using both the backport label and the branch prefix:

screen shot 2017-10-24 at 4 54 26 pm

@sorenlouv
Copy link
Owner

Makes sense. This should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants