Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backport label on repos where it exists #6

Closed
epixa opened this issue Oct 24, 2017 · 3 comments
Closed

Add backport label on repos where it exists #6

epixa opened this issue Oct 24, 2017 · 3 comments

Comments

@epixa
Copy link

epixa commented Oct 24, 2017

It's really useful for glancing at a list of PRs or auditing PRs to be able to filter away any PR that has a backport label, so it'd be great if this tool added that label automatically to all backport PRs.

@sorenlouv
Copy link
Owner

I tried doing this, but Github's API didn't seem to let me add labels to PRs. Will make this a priority now.

@epixa
Copy link
Author

epixa commented Oct 24, 2017

You may want to take a look at the elastic-jasper github code to see how I did it there. I can't remember off-hand

@sorenlouv
Copy link
Owner

sorenlouv commented Oct 30, 2017

@epixa I've created a PR #12 that allows the user to labels to their config file, which will be added to the backport PR. Like this:

{
  "name": "elastic/kibana",
  "versions": ["6.x", "6.0", "5.6", "5.5", "5.4"],
  "labels": ["backport"]
}

I also considered making it a handler (although that seems unnecessary for now)

{
  "name": "elastic/kibana",
  "versions": ["6.x", "6.0", "5.6", "5.5", "5.4"],
  "labels": version => something ? ["backport", version] : [version];

}

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants