Include app name in :pg group namespace
#1065
Conversation
|
I'm unsure if there are tests for this in the test directory. |
| @@ -50,7 +50,7 @@ defmodule Oban.Notifiers.PG do | |||
| @impl Notifier | |||
| def notify(server, channel, payload) do | |||
| with %{conf: conf} <- get_state(server) do | |||
| pids = :pg.get_members(__MODULE__, conf.prefix) | |||
| pids = :pg.get_members(__MODULE__, {conf.name, conf.prefix}) | |||
There was a problem hiding this comment.
This would be a breaking change for any app that relies on connecting different apps that share an oban_jobs table. Instead, I think the solution is to pass a namespace option through and have it fall back to conf.prefix.
In application config it would look like this:
notifier: {Oban.Notifiers.PG, namespace: {Oban, "public"}}WDYT?
There was a problem hiding this comment.
Funny enough @mbaleczny suggested something like that as well.
There was a problem hiding this comment.
@sorentwo I don't see how this would effect two apps connected to the same database using the same table. If both have the same name: then they will still communicate as normal but if the name: is different, then they won't communicate.
Either way, I do agree that this should probably be a configuration done with the :notifier. I don't know where all of that would need to change as my understanding is that :notifier is expected to be a module only.
There was a problem hiding this comment.
I don't see how this would effect two apps connected to the same database using the same table. If both have the same name: then they will still communicate as normal but if the name: is different, then they won't communicate.
That's the issue—if people are relying on the fact that two instances with different names (Oban.A and Oban.B) can communicate, then this would break their app.
I don't know where all of that would need to change as my understanding is that :notifier is expected to be a module only.
I can make the changes. It will look roughly like https://github.com/sorentwo/oban_notifiers_phoenix 🙂
There was a problem hiding this comment.
Cool, I'll close this PR then.
By default, all Oban instances using the same `prefix` option would receive notifications from each other. Now you can use the `namespace` option to separate instances that are in the same cluster _without_ changing the `prefix`. Addresses #1065
|
@warmwaffles Done! See the linked commit. |
We are running 4 separate elixir applications in the same cluster. Each application talks to each other using
:pg. But each application has its ownObaninstance running. We were running into issues where other nodes were showing up in the dashboard.I tried setting just
name: MyApp.Obanand on the dashboard router helperoban_name: MyApp.Oban. This did not work. Locally I made the following changes in mydeps/directory, recompiled and this seems to do the trick.If you have a better solution, feel free to close this. I just wanted to bring this up as potential solution.