Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to rename [:oban, :notifier, :switch] emitted log attribute status to connectivity_status #1086

Merged
merged 1 commit into from
May 18, 2024

Conversation

punchcafe
Copy link
Contributor

Hello Again!

This is a small change request to make the default telemetry logger integrate nicer with Datadog.

The logs emitted in response to [:oban, :notifier, :switch] events have a status field, which is a reserved field for JSON logs with Datadog. The result was that all :switch events were being treated as critical logs and raising alerts. I imagine a lot of Oban users use Datadog so I thought it may be worth making this small tweak to avoid conflict.

Thanks,
Luca

@sorentwo sorentwo merged commit 453f7c8 into sorentwo:main May 18, 2024
2 checks passed
@sorentwo
Copy link
Owner

@punchcafe Thanks! This is a welcome change; whatever we can do to ease integration with external tools is wonderful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants