-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Ruby 1.9.3 #5
Comments
Thanks for the suggestion. I'm not aware of any specific incompatibility with Ruby 1.9.3 so you are welcome to give it a try. However, 1.9.3 was end-of-lifed and no longer receives security updates. I won't be including it in the build matrix. |
I have tried, at least the incompatibility of using "key arguments." In an ideal world, yes, the old Ruby 1.9.3 and is no longer supported and is not used. However, in real systems, larger all different. |
Ah, I forgot about the keyword args in def initialize(marshal: Marshal, compress: false, threshold: DEFAULT_THRESHOLD)
@marshal = marshal
@compression = compress
@threshold = threshold
end to this: def initialize(options = {})
@marshal = options.fetch(:marshal, Marshal)
@compression = options.fetch(:compress, false)
@threshold = options.fetch(:threshold, DEFAULT_THRESHOLD)
end do it? If so, that change was made in |
I'll do it when I introduce your gem in the project. While there is no time. |
@Napolskih: No need, I've introduced the change. It's available on master and will be in the |
Good! And specs for travis on 1.9.3, yes? |
Nope, I don't want to encourage the continued use of 1.9.3. I understand people have real world cases where they can't get off 1.9 easily, and I want them to be able to use Readthis, but that isn't an official target. |
I did a fork the latest version. Run specs.
This is a bug: https://bugs.ruby-lang.org/issues/7414 I fixed it with replace Next, I got:
Ruby 1.9 not have a method to_h for Array. Specs passed for all rubies 😄 It's just check. I'm not going to use the gem in the project. Later. P.S. By the way, |
Thank you for all of your investigation into the compatibility issues. I wasn't aware of the namespaced module incompatibility for The performance of |
Maybe provide compatibility with Ruby 1.9.3 ?
The text was updated successfully, but these errors were encountered: