Handle case when nil is explicitly passed to fetch #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,6 +156,13 @@ def self.load(value) | |||
|
|
|||
| expect(cache.read('short-key')).to eq('other stuff') | |||
| end | |||
|
|
|||
| context 'handling passing nil to options' do | |||
There was a problem hiding this comment.
Spec looks right on. Can you drop the context and put more detail into the spec description instead?
|
Thanks for the fix. That pesky I left a couple of minor notes, but can you also add a changelog entry? |
I ran in to this issue while using the active model serializers gem version v0.10.0.rc3. They default their options that get passed to the cache as nil if none are set. Using an options hash doesn't guard against explicitly passed parameters, in this case nil. That caused an error, shown in the screenshot below. I hope this helps :)
dasnixon
force-pushed
the
fix/handle_fetch_options_nil
branch
from
b3a8068
to
9c2b6f9
Compare
|
@sorentwo updated, let me know if there is anything else. Appreciate the fast response and the awesome gem! 👍 |
sorentwo
added a commit
that referenced
this pull request
Oct 17, 2015
Handle case when nil is explicitly passed to fetch
|
Thanks for the patch @dasnixon! Glad you're getting use out of the gem =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran in to this issue while using the active model serializers gem
version v0.10.0.rc3.
They default their options that get passed to the cache as nil if
none are set. Using an options hash doesn't guard against explicitly
passed parameters, in this case nil. That caused an error, shown in
the screenshot below.
I hope this helps :)