Skip to content

Commit

Permalink
Re-enable repositioning of popover
Browse files Browse the repository at this point in the history
  • Loading branch information
emmenko committed Nov 20, 2013
1 parent e2773ee commit 72be4d7
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions build/js/bootstrap-tour.js
Expand Up @@ -412,6 +412,7 @@
}).popover("show");
$tip = $element.data("bs.popover") ? $element.data("bs.popover").tip() : $element.data("popover").tip();
$tip.attr("id", step.id);
this._reposition($tip, step);
if (isOrphan) {
return this._center($tip);
}
Expand Down

5 comments on commit 72be4d7

@emmenko
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LostCrew I saw you commented it here 6da5583#diff-4b41fd497af40b82703c33102067fc7cR350

Was there a reason or you just forgot to re-enable it? I noticed that since my app broke after the update.

I would like then to release a 0.7.1 version. Can I confirm it?

Thanks :)

@emmenko
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmenko
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorich87 @LostCrew can I release v0.7.1?

I'm still working on the events refactoring and need to write more tests. So I'll probably release that in v0.7.2.

@sorich87
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@emmenko
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright :)

Please sign in to comment.