Match paths with regexes

[evanleonard]

Hi again, I'm trying to use the "path" parameter, but running into an issue where my paths look like "/users/5647".

is it possible today to have a path like "/users/*" that will match the above current_path?

What I'm getting right now is an infinite redirect loop =(

[sorich87]

It's not possible but we'll consider it. Pull request welcome.

P.S.: I changed the issue title from How to use "path" with ids in it?.

[evanleonard]

Right, better title. It looks like you can somehow override isRedirect with a custom function today, is that true?

[sorich87]

Yes, you can do that.

[LostCrew]

@evanleonard right after you create an instance of your tour, you can simply redefine _isRedirect with your custom function:

var tour = new Tour();

// override default method
tour._isRedirect = function() {
    // custom _isRedirect logic
};

hope it helps.

[LostCrew]

@evanleonard are you gonna submit a pull request for the original purpose of the issue? can i instead close this issue?

[evanleonard]

Go ahead and close this. I was able to do what I need by overriding _redirect for now.

[sorich87]

Why not submit a pull request? Matching with regexes is a very useful feature. ;)

[emmenko]

I would also like to see a pull request :)

[LostCrew]

👍 i obviously prefer to receive a shiny pull-request as well!

[evanleonard]

As would I, of course. But time is limited, and i was able to solve my issue another way for now.

FWIW, here is my workaround:

this.tour._isRedirect = function(path, currentPath) {
var isRedirect = false;
if(path != null && path !== "") {
path = path.replace(/?.*$/, "").replace(//?$/, "");
currentPath = currentPath.replace(//?$/, "");
isRedirect = currentPath.indexOf(path) != 0;
}
return isRedirect;
}

Basically is accepts any path that starts with the value of the path option on the step. Then I also needed to get the tour to sync to the right step when the user goes to the new page, so added the following method in the flow:

_syncStep: function() {
var path = document.location.pathname;
if(this.tour._current==1 && path.indexOf("/roles/") == 0) {
this.tour.goto(2);
}
else if(this.tour._current==3 && path.indexOf("/roles/") == 0) {
this.tour.goto(4);
}
else if(this.tour._current==7 && path.indexOf("/roles/") == 0) {
this.tour.goto(6);
}
},

On Sep 29, 2013, at 1:04 PM, Emanuele notifications@github.com wrote:

i obviously prefer to receive a shiny pull-request as well!

—
Reply to this email directly or view it on GitHub.

[sorich87]

Fixed in 1a82a2b. You cannot set the path option to a value like ^/users/\d+$.

[luttor]

after redirect dont function the tour...

help me please!