Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the AMD loader #538

Closed
wants to merge 1 commit into from

Conversation

andrewnicols
Copy link

I'd quite like to use this library in a project I work on (moodle/moodle), however JS in Moodle is loaded via AMD/requireJS.

This patch adds support for requireJS by modifying the way in which it is loaded.

I'm afraid I don't quite know where to start with adding appropriate tests for this, but existing tests continue to pass.
I have also only submitted the coffee file and not the built files. Hope this is correct.

@sorich87
Copy link
Owner

sorich87 commented Jun 6, 2016

Merged with some modifications in 57ee748.

@andrewnicols how is the integration with Moodle going? anywhere I can follow it?

@sorich87 sorich87 closed this Jun 6, 2016
@andrewnicols
Copy link
Author

Hi,

I've created a plugin for the tours which applies to Moodle 3.0, and 3.1.

We hope to get this into Moodle 3.2 core, but currently face a number of issues with accessibility which we intend to feed back here.

At some point we will be looking to move to Bootstrap 4 too.

@sorich87
Copy link
Owner

sorich87 commented Jun 6, 2016

Thanks @andrewnicols. Can't wait to read your feedback about accessibility!

@sorich87
Copy link
Owner

sorich87 commented Jun 6, 2016

There's a discussion about Bootstrap 4 here #554.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants