move common prompt to external function

[Eriner]

No description provided.

[sorin-ionescu]

Why are you exporting it?

[Eriner]

I believe the comment is self-explanatory. To go into more detail, if it isn't exported, the variable isn't available to the calling function ex: prompt_damoekri_setup.

An alternative way of handling it would be to create local dir and assign what is currently being exported to that, then at the end of the function, echo ${dir}. Inside the prompt setups, they could just assign the output of that to a variable and use that instead.

If you know of a better way to handle it, please let me know and I will commit a change.

[Eriner]

This would close issue #701

[amerlyq]

Hm, I have slightly different approach to this problem as whole -- I have splitted all prompt into keyparts to make it modular. See at prompt and prompt.d. Not ideal, of course, but allows much more control.

[sorin-ionescu]

Your prompts will share styling. In this case, it's just one function, no styling.

[belak]

Nit: should be "reduce"

[belak]

I'm merging this into a temp branch so I can make a tweak and cherry-pick it to master. I guess weird things happen when a repo is deleted while there are still PRs open.

[belak]

This has been merged into master along with some spelling fixes and a fix to ensure extendedglob is set for this function. Thanks for your contribution!

[sorin-ionescu]

Be careful with those functions. They are not always completely identical. I was trying to think of a naming scheme since promptpwd is not descriptive enough.

[belak]

Maybe shortpwd or something similar?

[sorin-ionescu]

It's still doesn't say how short it is and what's included.