keeper: add pg_rewind support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This patch adds pg_rewind support. By default it's disabled and can be enabled setting the `use_pg_rewind` cluster config options to true. Since pg_rewind needs to connect to the master instance with a superuser role, the superuser credential needs to be provided (currently at startup using environment variables or options (discouraged)) to all the `stolon-keeper` processes. For security reason they cannot be provided inside the cluster config. It'll also work with synchronous replication (pg_rewind needs to connect with `synchronous_commit` disabled at its session level). Add related tests. Add related documentation.
|
@s-hironobu @shaneog Merging this (it's working well and can be changed/improved in future). If you're going to test pg_rewind support please report issues or feature requests. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds pg_rewind support. By default it's disabled and can be
enabled setting the
use_pg_rewindcluster config options to true.Since pg_rewind needs to connect to the master instance with a superuser
role, the superuser credential needs to be provided (currently at
startup using environment variables or options (discouraged)) to all the
stolon-keeperprocesses. For security reason they cannot be providedinside the cluster config.
It'll also work with synchronous replication (pg_rewind needs to connect
with
synchronous_commitdisabled at its session level).Add related tests.
Add related documentation.