*: Only use PGParameters from the cluster spec. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
force-pushed
the
only_cluster_spec_pgparameters
branch
4 times, most recently
from
b312f3c
to
1e5dcea
Compare
With this patch the postgresql.conf will only include the defined pgParameters in the cluster spec and will not include other config files anymore. This makes the postgres config handling more consistent and let us really handle it in a centralized fashion without surprises. When initializing a cluster we'd like to retain the previous pg parameters: * When initMode is new: the one created by initdb when initializing a new db * When initMode is existing: the current instance parameters * When handling point in time recovery: the parameters provided by the restored instance. For doing this, the keeper will, during initialization, rename and include the existing `postgresql.conf`, get the list of the modified parameters, report them to the sentinel that will merge them back in the cluster spec.
sgotti
force-pushed
the
only_cluster_spec_pgparameters
branch
from
1e5dcea
to
a06394a
Compare
sgotti
added a commit
that referenced
this pull request
Nov 9, 2016
*: Only use PGParameters from the cluster spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch the postgresql.conf will only include the defined
pgParameters in the cluster spec and will not include other config files
anymore.
This makes the postgres config handling more consistent and let us really
handle it in a centralized fashion without surprises.
When initializing a cluster we'd like to retain the previous pg
parameters:
restored instance.
For doing this, the keeper will, during initialization, rename and
include the existing
postgresql.conf, get the list of the modifiedparameters, report them to the sentinel that will merge them back in the
cluster spec.