keeper: validate id against postgres repl slot name rules. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the keeper's id is used as the postgres replication slot name it needs to be a valid replication slot name. From the postgreSQL 9.4 manual: "Each replication slot has a name, which can contain lower-case letters, numbers, and the underscore character."
sgotti
force-pushed
the
keeper_check_id_valid_replication_slot_name
branch
from
06fdd78
to
c2dedd3
Compare
sgotti
added a commit
that referenced
this pull request
Oct 30, 2015
…slot_name keeper: validate id against postgres repl slot name rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the keeper's id is used as the postgres replication slot name it needs to
be a valid replication slot name.
From the postgreSQL 9.4 manual: "Each replication slot has a name, which can
contain lower-case letters, numbers, and the underscore character."