Expose repack from an executable #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-David
changed the title
|
Thank you! I'll take a look at conda packaging and release new version with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for no response to PR #21 . Although the previous one was merged but here I'd like to improve it following @sorki 's advice.
Here, the executable called
emnist_repacktakes two arguments, one for the emnist data and another is the output directory. If theoutputis not set, the program will write the output file into the original place but addrf_(stands for rotate fix) before it. Otherwise, files will be saved with same filename in theoutputdirectory. Also if anyone specify theoutputas same asdata, I think he may want to override.