Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-jdk.sh 2019-04-17 fails for OpenJDK11 #47

Closed
ncik-roberts opened this issue Apr 18, 2019 · 4 comments
Closed

install-jdk.sh 2019-04-17 fails for OpenJDK11 #47

ncik-roberts opened this issue Apr 18, 2019 · 4 comments
Assignees

Comments

@ncik-roberts
Copy link

$ ./install-jdk.sh --dry-run --license GPL --feature 11 --os linux-x64
install-jdk.sh 2019-04-17
Couldn't determine a download url for 11-GPL on linux-x641

This appears unrelated to #46, since I continue to get the same error message even when reverting fe56033, which was applied to fix that issue.

I think the root of the problem might be that early access for JDK 11 has ended: https://jdk.java.net/11/

Cf. 10 and 12:

$ ./install-jdk.sh --dry-run --license GPL --feature 10 --os linux-x64
install-jdk.sh 2019-04-17
Variables:
  feature = 10
  license = GPL
       os = linux-x64
      url = https://download.java.net/java/GA/jdk10/10.0.2/19aef61b38124481863b1413dce1855f/13/openjdk-10.0.2_linux-x64_bin.tar.gz
   status = 200
  archive = /home/nick/openjdk-10.0.2_linux-x64_bin.tar.gz
$ ./install-jdk.sh --dry-run --license GPL --feature 12 --os linux-x64
install-jdk.sh 2019-04-17
Variables:
  feature = 12
  license = GPL
       os = linux-x64
      url = https://download.java.net/java/GA/jdk12.0.1/69cfe15208a647278a19ef0990eea691/12/GPL/openjdk-12.0.1_linux-x64_bin.tar.gz
   status = 200
  archive = /home/nick/openjdk-12.0.1_linux-x64_bin.tar.gz
@sormuras sormuras self-assigned this Apr 18, 2019
@sormuras
Copy link
Owner

sormuras commented Apr 18, 2019

I think the root of the problem might be that early access for JDK 11 has ended: https://jdk.java.net/11/

Copied from the JDK 11 site

JDK 11 Releases
The JDK 11 Early Access Program has concluded. Please visit Java SE Downloads for production ready builds.
Older releases, which do not include the most up to date security vulnerability fixes and are no longer recommended for use in production, remain available in the OpenJDK Archive.

I'll change the script to support the archived JDK 11.0.2 version -- but recommend to switch to 12.

sormuras added a commit that referenced this issue Apr 18, 2019
@sormuras
Copy link
Owner

Seems the "old and archived" OpenJDK 11.0.2 is loading correctly now: https://travis-ci.org/sormuras/sormuras.github.io/jobs/521891895

Wondering, if install-jdk.sh should redirect 11 request to another distro, that keeps 11 "alive", like @AdoptOpenJDK 's 11.0.3 version downloaded here: https://travis-ci.org/sormuras/sormuras.github.io/jobs/521891903

@JoeHegarty
Copy link

JoeHegarty commented Apr 18, 2019

It would be really great if we could get support for the LTS versions of the JDK.

8 and 11 have LTS releases from Amazon (Corretto) and Azul (Zulu) and as you pointed out AdoptJDK has 11.0.3 outside of the normal releases.

I suspect a lot of library developers would like to run against these in the long term as it's likely a lot of JDK users (particularly corporate) will settle on 8/11 LTS versions from these vendors.

For those of us using Travis, it would be great if we could use like zulu11 corretto8 etc as versions. I'm not 100% sure what the relationship between travis and this script is.

Clearly it isn't your fault and lies with Oracle/OpenJDK, but the frequent breakages recently where versions just disappear is extremely disruptive, so being able to rely on a version/vendor we know will be around for a long time would be a big bonus.

@sormuras
Copy link
Owner

Thanks for your comment, @JoeHegarty

install-jdk.sh supports any vendor's release via its --url option. See this file for usage examples: https://github.com/sormuras/sormuras.github.io/blob/master/.travis.yml
It requires you to use the raw version of this script, though. As Travis CI...

For those of us using Travis, it would be great if we could use like zulu11 corretto8 etc as versions. I'm not 100% sure what the relationship between travis and this script is.

...as Travis CI hosts a copy of this script and redirects some its jdk: xyz targets to it, hiding all other options provided by install-jdk.sh.

Copied from https://github.com/sormuras/bach#install-jdksh - install-jdk.sh main purpose is to install the latest-and-greatest available OpenJDK release from jdk.java.net. I already started to drop support for Oracles JDKs (from version 12 on) and won't add "manually curated" support for other vendors. An exception might be vendors that offer an API like https://api.adoptopenjdk.net does.

Clearly it isn't your fault and lies with Oracle/OpenJDK, but the frequent breakages recently where versions just disappear is extremely disruptive

OpenJDK should offer such an API as described above. /cc @robilad

so being able to rely on a version/vendor we know will be around for a long time would be a big bonus.

@travis-ci should make use of another tool, like @sdkman or @shyiko 's jabba or others, to support GA'ed versions of JDKs. The focus of install-jdk.sh is and remains OpenJDK. Perhaps, I should rename it accordingly: install-openjdk.sh... ;-)

That being said, I close this issue about OpenJDK 11 not working.

kwin added a commit to kwin/acs-aem-commons that referenced this issue May 24, 2019
@sormuras sormuras assigned sormuras and unassigned sormuras Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants