Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for file based hazelcast.xml loading as well as class path hazelcast.xml loading #12

Closed
ekskimn opened this issue Jun 21, 2019 · 4 comments
Assignees

Comments

@ekskimn
Copy link

ekskimn commented Jun 21, 2019

No description provided.

@ekskimn
Copy link
Author

ekskimn commented Jun 21, 2019

We are using the library but we need to be able to pass the hazelcast.xml config by file reference out side of the class path. But because you're only using

 new ClasspathXmlConfig(config.getString("config-file"))

we can't reference files outside of the class path. It would be great to allow use of

new FileSystemXmlConfig(config.getString("config-file"))

@sorokinigor
Copy link
Owner

Hi @ekskimn ,
It sounds like an easy change, I will take care of it this week.

@sorokinigor
Copy link
Owner

sorokinigor commented Jun 30, 2019

@ekskimn
I have published 1.1.1 version with the fix ( 'com.github.sorokinigor:akka-persistence-hazelcast_2.11:1.1.1').
It should be available within a day (it depends on Maven Central).

@sorokinigor sorokinigor self-assigned this Jun 30, 2019
@ekskimn
Copy link
Author

ekskimn commented Jul 1, 2019

@sorokinigor awesome~! thank you~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants