-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README with dependency and note about double opt-in #1
Conversation
Fantastic, thanks Dan, I'll get these changes merged in next week. Shall keep you posted. Rob Hi, thanks for the gem, works a treat, just what we we're after! [image: I was getting an 'Unitialized Constant' from Also added a note to say that by default 'double opt-in' for subscribers is Thanks for sharing! DanYou can view, comment on, or merge this pull request online at: #1
File Changes Patch Links:
— |
Morning Dan, I'm just taking another look at this, and I note that Gibbon is listed in the gemspec as a runtime dependancy so should be installed along with the devise_campaignable gem, you shouldn't have to install it by yourself. How did you install devise_campaignable? Did you use bundler? Or install in manutally using 'gem install...'? Thanks, Rob |
I saw this same 'Uninitialized Constant' referring to Gibbon on a friend's project. It was fixed by explicitly including the Gibbon dependency on the Gemfile, but unfortunately I couldn't investigate more to find the cause of this. |
@jaimeiniesta thanks for letting me know. This quite odd, perhaps it's a versioning issue whereby it can't find the right version of gibbon. Clearly an issue so I'll merge in this PR and tackle the core issue later. |
Updated README with dependency and note about double opt-in
Apologies, hadn't seen your reply until now! I installed via bundler! :) |
BTW, I could reproduce this bug as well, I had to explicitly include |
Thanks for the heads up on this. Still confused as Gibbon is listed in the Gemspec as a runtime dependancy. I have created issue #4 to track progress. If you have any ideas or comments drop them under the new issue. |
Hi, thanks for the gem, works a treat, just what we we're after! 👍
I was getting an 'Unitialized Constant' from 'lib/devise_campaignable/adapters/mailchimp.rb:78'
until i added Gibbon to my gemfile. So just updated the readme with a note to install this too! :)
Also added a note to say that by default 'double opt-in' for subscribers is set to false (as this was a plus point worth mentioning for me!)
Thanks for sharing!
Dan