Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision to serve assests from private s3 buckets #48

Closed
xtroncode opened this issue Apr 14, 2020 · 2 comments · Fixed by #53
Closed

Provision to serve assests from private s3 buckets #48

xtroncode opened this issue Apr 14, 2020 · 2 comments · Fixed by #53
Assignees
@agoldis

Comments

@xtroncode
Copy link
Contributor

  • the ACL used for generating upload url is public-read due to which upload fails for private buckets
  • Can we make the readUrl configurable such that we can serve s3 assets from a private bucket via a proxy or can we have signed get urls in the dashboard ?
@agoldis agoldis self-assigned this Apr 14, 2020
@agoldis agoldis mentioned this issue Apr 15, 2020
Merged
@agoldis
Copy link
Collaborator

agoldis commented Apr 15, 2020

@xtroncode thanks for opening the request!

Should be configurable in https://github.com/agoldis/sorry-cypress/releases/tag/v0.2.4
also updated the documentation https://github.com/agoldis/sorry-cypress/wiki/S3-screenshot-driver

@xtroncode xtroncode mentioned this issue Apr 16, 2020
Merged
@agoldis
Copy link
Collaborator

agoldis commented Apr 16, 2020

@xtroncode sorry, 2.0.4 is buggy, releasing 2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agoldis agoldis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add S3 ACL and S3_READ_URL_PREFIX customization sorry-cypress/sorry-cypress
2 participants
@agoldis @xtroncode