Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some quality control #143

Closed
hueitan opened this issue Jul 2, 2015 · 8 comments
Closed

Some quality control #143

hueitan opened this issue Jul 2, 2015 · 8 comments

Comments

@hueitan
Copy link
Collaborator

hueitan commented Jul 2, 2015

Perhaps we need some Quality control for the repo. Otherwise all the JavaScript related project can be PR here. JavaScript is a huge and this list can be spammed. 馃憥

@Waterloo
Copy link
Contributor

Waterloo commented Jul 2, 2015

How about adding javascript with certain threshold of stars in github

@arthurvr
Copy link
Contributor

arthurvr commented Jul 2, 2015

How about adding javascript with certain threshold of stars in github

Quality of something isn't the same as its popularity.

@hueitan
Copy link
Collaborator Author

hueitan commented Jul 10, 2015

Quality of something isn't the same as its popularity.

Agree with that.

@arthurvr what's your experience about the QC?

@arthurvr
Copy link
Contributor

Making black-on-white rules about something like this is really difficult. The most important part is that you should try to be strict when merging PRs.

Is the project still maintained? Does it have proper documentation? Is it well tested? Isn't the idea behind this project outdated? What's the use-case?

All of these never give a perfect view of a project, but are really good indicators. It's going to cause annoying discussions but you should try to be hard and say "no thanks" to more things.

Also, frequently read through the list yourself and remove everything which doesn't deserve there.

@zhouzi
Copy link
Contributor

zhouzi commented Aug 9, 2015

Maybe you could make a small group of people/contributors to vote for each addition and accept the PR if the majority voted for it.

@hueitan
Copy link
Collaborator Author

hueitan commented Aug 10, 2015

@zhouzi still having the same problem that @arthurvr mentioned

Quality of something isn't the same as its popularity.

@zhouzi
Copy link
Contributor

zhouzi commented Aug 10, 2015

It would be up to the group of people you selected to review and judge of a suggestion's quality based on some criteria. However this might be a bit of work so I think the idea of @arthurvr is great. You can have some fixed rules and see if the PRs follow them.

@hueitan hueitan mentioned this issue Aug 21, 2015
@hueitan
Copy link
Collaborator Author

hueitan commented Sep 1, 2015

No idea for now. Let's see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants