Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Error? #35

Closed
invertedspear opened this issue Mar 24, 2017 · 3 comments
Closed

Documentation Error? #35

invertedspear opened this issue Mar 24, 2017 · 3 comments

Comments

@invertedspear
Copy link
Contributor

SystemJS configuration instructs to add "'angular-sortablejs': 'node_modules/angular-sortablejs'" to that map object. But when I do I get a 404 looking for "/node_modules/angular-sortablejs/index.js". After peeking at what was installed into node_modules it looks like the index.js is in the "dist" subfolder. I updated the map object with the dist subfolder which got the package working for me.

Is the documentation correct and did I do something wrong? or is the documentation just missing that subfolder?

@smnbbrv
Copy link
Member

smnbbrv commented Mar 25, 2017

Hi @invertedspear

most likely the documentation is wrong because I'm using webpack in my projects and this particular piece of documentation was done once upon a time in the really beginning (there were structural changes after).

Could you update the docs with the proper setup and make a pull request?

I would be grateful for this

@invertedspear
Copy link
Contributor Author

Hey @smnbbrv,

I'm really new to Git and Github. I think I did things right, but since this is a first, please provide some feedback if I didn't.

Thanks

@smnbbrv
Copy link
Member

smnbbrv commented Mar 28, 2017

Hi @invertedspear

thank you for you contribution, everything is fine 👍

@smnbbrv smnbbrv closed this as completed Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants